Skip to content

Feat/expo scan overlay debug fixes#34

Merged
TriForMine merged 2 commits into
mainfrom
feat/expo-scan-overlay-debug-fixes
May 29, 2026
Merged

Feat/expo scan overlay debug fixes#34
TriForMine merged 2 commits into
mainfrom
feat/expo-scan-overlay-debug-fixes

Conversation

@TriForMine

@TriForMine TriForMine commented May 29, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings May 29, 2026 08:18
@coderabbitai

coderabbitai Bot commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@TriForMine, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 58 minutes and 38 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 95ac1b52-00b7-4626-a932-6314aa70e9f4

📥 Commits

Reviewing files that changed from the base of the PR and between c264fa7 and c56a289.

⛔ Files ignored due to path filters (1)
  • apps/expo-glyphnet/bun.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • apps/expo-glyphnet/package.json
  • apps/expo-glyphnet/src/features/encode/EncodePanel.tsx
  • apps/expo-glyphnet/src/features/scan/ScanPanel.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/expo-scan-overlay-debug-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TriForMine TriForMine force-pushed the feat/expo-scan-overlay-debug-fixes branch from a1d70ea to c56a289 Compare May 29, 2026 08:20
@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

Burst reliability (loss sweep)

✅ PR gate status: PASS

  • Gating rows: 4 pass / 0 fail
  • Non-gating rows: none
Drop rate Gating PR success Base success Delta PR median frames Base median frames
10% Yes 100.0% 100.0% 0.0pp 14 14
20% Yes 100.0% 100.0% 0.0pp 16 16
30% Yes 100.0% 100.0% 0.0pp 19 19
40% Yes 50.0% 50.0% 0.0pp 18 18

Copilot AI reviewed May 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

Scanner perf (ribbon + matrix fixtures)

✅ PR gate status: PASS

  • Ribbon budget: 25.000 ms (allowed 75.000 ms)
  • Matrix budget: 20.000 ms (allowed 60.000 ms)
  • Tolerance: 200.0%
  • Ribbon gating benches: 3 pass / 0 fail
  • Matrix gating benches: 1 pass / 0 fail
Benchmark Gating PR median (ms) Base median (ms) Delta (ms) Delta %
scan_generated_ribbon_canvas_small (RibbonPrint) Yes 47.807 47.953 -0.146 -0.30%
scan_generated_ribbon_canvas_medium (RibbonPrint) Yes 7.142 7.139 0.003 0.05%
scan_generated_ribbon_canvas_large (RibbonPrint) Yes 25.754 25.742 0.012 0.05%
scan_generated_matrix_roi (MatrixCompat) Yes 3.029 3.031 -0.002 -0.06%
scan_generated_matrix_canvas (MatrixCompat) No 183.071 184.131 -1.060 -0.58%
scan_real_debugger_screenshot (RibbonPrint) No 281.201 283.632 -2.431 -0.86%

Matrix subset

Benchmark Gating PR median (ms) Base median (ms) Delta (ms) Delta %
scan_generated_matrix_roi (MatrixCompat) Yes 3.029 3.031 -0.002 -0.06%
scan_generated_matrix_canvas (MatrixCompat) No 183.071 184.131 -1.060 -0.58%

@TriForMine TriForMine merged commit a482d29 into main May 29, 2026
10 checks passed
@TriForMine TriForMine deleted the feat/expo-scan-overlay-debug-fixes branch May 29, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TriForMine